Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isDisplayed in devtools #4477

Merged
merged 1 commit into from Sep 10, 2019
Merged

Fix isDisplayed in devtools #4477

merged 1 commit into from Sep 10, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Sep 10, 2019

Proposed changes

fix isDisplayed, fixes #4475

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk added PR: Bug Fix 🐛 PRs that contain bug fixes devtools DevTools protocol labels Sep 10, 2019
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #4477 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4477   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         188      188           
  Lines        4755     4755           
  Branches     1016     1016           
=======================================
  Hits         4720     4720           
  Misses         32       32           
  Partials        3        3
Impacted Files Coverage Δ
...es/webdriverio/src/commands/element/isDisplayed.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade5c7c...d589225. Read the comment docs.

@christian-bromann christian-bromann merged commit ce06154 into webdriverio:master Sep 10, 2019
@mgrybyk mgrybyk deleted the fix-isdisplayed-devtools branch September 16, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools DevTools protocol PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isDisplayed doesn't work in firefox and chrome headless mode
2 participants