Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchAction should be used with Appium #4598

Merged
merged 1 commit into from Oct 9, 2019
Merged

touchAction should be used with Appium #4598

merged 1 commit into from Oct 9, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Oct 9, 2019

Proposed changes

Show better error if touchAction is used not with Appium.

[chrome  mac os x #0-0] Error: touchAction can be used with Appium only.

Types of changes

  • polish

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

#4595

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #4598 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4598      +/-   ##
==========================================
+ Coverage   99.32%   99.32%   +<.01%     
==========================================
  Files         193      193              
  Lines        5034     5036       +2     
  Branches     1080     1081       +1     
==========================================
+ Hits         5000     5002       +2     
  Misses         31       31              
  Partials        3        3
Impacted Files Coverage Δ
packages/webdriverio/src/commands/constant.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c733ff9...03f105e. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit f321067 into webdriverio:master Oct 9, 2019
@mgrybyk mgrybyk deleted the better-error-touchAction branch November 4, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants