Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default configs being exported as a singleton #4923

Conversation

naorzr
Copy link
Contributor

@naorzr naorzr commented Dec 26, 2019

Proposed changes

This pr is suppose to fix this bug issue #4922.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


**** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #4923 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4923   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         210      210           
  Lines        5486     5486           
  Branches     1200     1200           
=======================================
  Hits         5453     5453           
  Misses         30       30           
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-config/src/constants.js 100% <ø> (ø) ⬆️
packages/wdio-config/src/lib/ConfigParser.js 99.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3717d0...e081d74. Read the comment docs.

@naorzr naorzr force-pushed the fix-default-configs-being-exported-as-a-singleton branch from fb7f2bd to e081d74 Compare December 26, 2019 15:55
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

packages/wdio-config/src/lib/ConfigParser.js Show resolved Hide resolved
@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version PR: Bug Fix 🐛 PRs that contain bug fixes labels Dec 26, 2019
@christian-bromann christian-bromann merged commit 11a95f5 into webdriverio:master Dec 28, 2019
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants