Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some wording issues in the selector docs #4939

Merged
merged 2 commits into from Jan 13, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

Minor issue with the selector docs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added PR: Docs 📝 PRs that contain changes to the documentation backport-requested PRs with this label are considered to be applied to the last maintained version labels Jan 3, 2020
@christian-bromann christian-bromann requested a review from a team January 3, 2020 19:18
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #4939 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4939      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files         210      210              
  Lines        5535     5607      +72     
  Branches     1211     1240      +29     
==========================================
+ Hits         5503     5575      +72     
  Misses         29       29              
  Partials        3        3
Impacted Files Coverage Δ
packages/webdriver/src/request.js 100% <0%> (ø) ⬆️
packages/wdio-runner/src/utils.js 100% <0%> (ø) ⬆️
packages/wdio-config/src/utils.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808ba34...1918ab8. Read the comment docs.

@christian-bromann
Copy link
Member Author

christian-bromann commented Jan 13, 2020

@erwinheitzman added note to Partial Link Text as well. Anything else?

@erwinheitzman
Copy link
Member

@christian-bromann looks ready to be merged :)

@christian-bromann christian-bromann merged commit 6eae4aa into master Jan 13, 2020
@christian-bromann christian-bromann deleted the cb-selector-docs-improvements branch January 13, 2020 12:56
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Jan 17, 2020
christian-bromann added a commit that referenced this pull request Jan 17, 2020
* fix some wording issues in the selector docs

* add note to 'Partial Link Text' too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants