Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data table variable values in Cucumber scenario outlines #5448

Merged
merged 2 commits into from Jun 8, 2020
Merged

Fix data table variable values in Cucumber scenario outlines #5448

merged 2 commits into from Jun 8, 2020

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented May 29, 2020 •
edited

Proposed changes

Fix data table variable values in Cucumber scenario outlines #5434

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me so far .. anything I can do to help land this?

@christian-bromann christian-bromann mentioned this pull request Jun 8, 2020
Closed
@mgrybyk
Copy link
Member Author

mgrybyk commented Jun 8, 2020

I have time to complete everything on this one today

christian-bromann
christian-bromann approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgrybyk mgrybyk added PR: Bug Fix 🐛 PRs that contain bug fixes and removed work-in-progress labels Jun 8, 2020
@mgrybyk mgrybyk marked this pull request as ready for review June 8, 2020 11:54
@mgrybyk mgrybyk merged commit 63c9a3b into webdriverio:master Jun 8, 2020
@mgrybyk mgrybyk deleted the cucumber-table-vars branch August 27, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgrybyk @christian-bromann