Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depcrecated usage of rejectUnauthorized #5463

Merged
merged 1 commit into from Jun 8, 2020
Merged

Fix depcrecated usage of rejectUnauthorized #5463

merged 1 commit into from Jun 8, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

Currently WebDriver logs warnings like this:

(node:33087) DeprecationWarning: Got: "options.rejectUnauthorized" is now deprecated, please use "options.https.rejectUnauthorized"

This patch fixes this deprecation warning.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 4, 2020
@christian-bromann christian-bromann requested a review from a team June 4, 2020 20:35
wswebcreation
wswebcreation approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit a5bc76e into master Jun 8, 2020
@christian-bromann christian-bromann deleted the cb-fix-got-warning branch June 8, 2020 06:26
@gjvoosten gjvoosten mentioned this pull request Jun 8, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christian-bromann @wswebcreation