Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency of @wdio/sauce-service on @wdio/utils #5627

Merged

Conversation

lfdebrux
Copy link
Contributor

@wdio/sauce-service needs @wdio/utils v6.3.0 or later (with isW3C exported).

Otherwise you will get an error TypeError: (0, _utils.isW3C) is not a function from the onPrepare hook of @wdio/sauce-service.

Proposed changes

Bump dependency @wdio/utils to ^6.3.0.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Sorry, I introduced this bug in my PR #5610, as I didn't think about how the version numbers should look when adding @wdio/utils as a dependency to @wdio/sauce-service.

Reviewers: @webdriverio/project-committers

@wdio/sauce-service needs @wdio/utils v6.3.0 or later (with isW3C
exported).
@lfdebrux lfdebrux changed the title Fix dependency on @wdio/utils Fix dependency of @wdio/sauce-service on @wdio/utils Jul 16, 2020
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 16, 2020
@christian-bromann christian-bromann merged commit f29330c into webdriverio:master Jul 16, 2020
@christian-bromann
Copy link
Member

Released as v6.3.1

@lfdebrux lfdebrux deleted the fix-sauce-service-deps branch July 17, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants