Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wdio-rerun-service entries to Webdriver.IO #5740

Merged
merged 3 commits into from Aug 24, 2020
Merged

Add wdio-rerun-service entries to Webdriver.IO #5740

merged 3 commits into from Aug 24, 2020

Conversation

mikesalvia
Copy link
Contributor

@mikesalvia mikesalvia commented Aug 18, 2020

Proposed changes

Adds wdio-rerun-service to the wdio-cli constants.js, also there is a bug in the Custom Services page of website that points contributors to an incorrect location.

NPM link: https://www.npmjs.com/package/wdio-rerun-service
GitHub link: https://github.com/jwplayer/wdio-rerun-service
Medium link: https://medium.com/jw-player-engineering/allow-re-running-failed-tests-in-easily-in-webdriverio-813ab08ad743

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@mikesalvia
Copy link
Contributor Author

@christian-bromann Is this the only place I should update the available service?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikesalvia please also add it to /scripts/docs-generation/3rd-party/services.json, thanks!

@mikesalvia
Copy link
Contributor Author

@christian-bromann All done!

@mikesalvia mikesalvia changed the title Update constants.js in wdio-cli with wdio-rerun-service Add wdio-rerun-service entries to Webdriver.IO Aug 24, 2020
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor formatting issue

scripts/docs-generation/3rd-party/services.json Outdated Show resolved Hide resolved
To fix leading space

Co-authored-by: Christian Bromann <github@christian-bromann.com>
@mikesalvia
Copy link
Contributor Author

Accepted and merged in.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Aug 24, 2020
@christian-bromann christian-bromann merged commit 6ecf7e5 into webdriverio:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants