Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for change #6030 #6037

Merged
merged 29 commits into from Oct 26, 2020
Merged

Update docs for change #6030 #6037

merged 29 commits into from Oct 26, 2020

Conversation

dagoud
Copy link
Contributor

@dagoud dagoud commented Oct 26, 2020

Proposed changes

This updates the website API docs page for the new element commands merged in by:

#6030

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

dagoud and others added 29 commits September 13, 2020 20:26
@dagoud
DG 4019: add prev and next to package
38571cf
@dagoud
DG prev and next added to tests
d4a3dd9
@dagoud
DG No issue: fix trailing space
45a441d
@dagoud
DG 4019: Add parentElement to package
01af70f
@dagoud
DG 4019: remove getbrowserObj and add unit tests
3aef77d
@dagoud
DG merge upstream/master
76a0f6f
@dagoud
DG 4019: Add documentation to next and prev
0b7e53a
@dagoud
DG 4019: update docs and add test for parentEl
dcbf10d
@dagoud
DG 4019: amend naming of commands and update tests
0cff718
@dagoud
DG 4019: fix eslint issues
4863374
@dagoud
DG 4019: update jsdoc
ff12ee5
@dagoud
DG 4019: update jsdoc to use p element example
d7083da
@dagoud
DG 4019: upstream merge
f595ecc
@dagoud
DG 4019: add ignore for jest unit tests
8045dbd
@dagoud
DG 4019: amend error msg for when no prev or next Sibling available
d75003e
@dagoud
DG fix eslint errors
8ff8a41
@dagoud
DG resolve conflicts
fe521cb
@christian-bromann
add more tests
555dd0e
@dagoud
DG 4019: resolve merge conflicts
99e4b44
@dagoud
Merge remote-tracking branch 'upstream/master' into DG-4019
f2bbf79
@dagoud
DG 4019: Amend implicitWait to use includes() for String
7bcd5a6
@dagoud
DG 4019: Add error test for parentElement
76e0924
@dagoud
DG 4019: final changes to make tests pass for Mocha
17b3da9
@dagoud
DG 4019: fix trailing spaces in got
7091169
@dagoud
DG 4019: fix next and previous tests
ebe4add
@dagoud
DG 4019: amend nextElement test
ce2b6b6
@dagoud
DG Update docs post merge of 6030
881afdb
@dagoud
DG resolve conflicts
7bc4f73
@dagoud
DG Update docs post merge of 6030
818d4f9
christian-bromann
christian-bromann approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Oct 26, 2020
@christian-bromann christian-bromann merged commit 7776d7b into webdriverio:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dagoud @christian-bromann