Another take on bug #4953

[oversizedhat]

Proposed changes

Bug fix to #4953, as discussed in #5040

Hard to say if this solves all issues. I have not added any kind of extensive testing of it but it at least looks like it solves our case where we use mocha framework in combo with wdio. Have not tested any other scenarios like when using cucumber.

The "currentTest" addition to the hook seems to have been expected as its is already used (but ignored) in https://github.com/webdriverio/webdriverio/blob/master/packages/wdio-mocha-framework/src/index.js

Types of changes

• [x ] Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ oversizedhat
❌ oversizedhat-bot

[christian-bromann]

I think if this solves the issue for at least Mocha test it is already a step forward. One comment on the implementation.

@BorisOsipov any thoughts?

[BorisOsipov]

@christian-bromann I dont mind.

[christian-bromann]

@oversizedhat please address the comment above and add a unit test for your changes in the Allure reporter. Let me know if you need and help.

[oversizedhat]

cheers @christian-bromann I will take a look into adding some tests

[christian-bromann]

@oversizedhat the change looks good to me, can you squash all commits into one so that the CLA bot is happy? Cheers!

[oversizedhat]

cheers @christian-bromann, will try to wrap it up. Still want to add some kind of test to validate the change too, it was a valid comment.

[oversizedhat]

@christian-bromann cleaned it up now and added at least some basic test to validate that there are no test duplicates in the allure report due to hook start. There is room for more testing but its something at least

[christian-bromann]

Awesome, LGTM 👍