Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply base url if not empty string #6582

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

christian-bromann
Copy link
Member

Proposed changes

If someone has an empty string in their base url it would have cause WebdriverIO to throw an error:

   "TypeError [ERR_INVALID_URL]: Invalid URL:
     at onParseError (internal/url.js:256:9)
     at new URL (internal/url.js:332:5)
     at new URL (internal/url.js:329:22)
    at Browser.url (/xxxxx/node_modules/webdriverio/build/commands/browser/url.js:43:17)"

This patch ensure that the string is not empty.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

refs #6460

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 12, 2021
@christian-bromann christian-bromann requested a review from a team March 12, 2021 12:44
@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Mar 12, 2021
@christian-bromann christian-bromann merged commit a9ffc13 into main Mar 12, 2021
@christian-bromann christian-bromann deleted the cb-fix-empty-baseurl branch March 12, 2021 14:22
@larryg01
Copy link
Contributor

@christian-bromann will this be included in the latest update v7.1.2 ?

@christian-bromann
Copy link
Member Author

No, it will be included in the upcoming release.

@larryg01
Copy link
Contributor

Ok thank you. I need this before i can push out an update of my framework

This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review These Pull Requests require review from project members PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants