Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection details setting for multiremote in selenium server #6681

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

Fixes: #6652

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 9, 2021
@christian-bromann christian-bromann requested a review from a team April 9, 2021 07:41
@christian-bromann
Copy link
Member Author

@erwinheitzman I refined the types. I need to check twice because in the first time I need to decided whether to get the capabilities from a multiremote object vs. a set of caps and second I need to decide to attach the new options to the caps directly or to the multiremote options. I don't see a better way to do this.

@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Apr 12, 2021
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit 3530692 into main Apr 13, 2021
@christian-bromann christian-bromann deleted the cb-fix-multiremote-selenium-server branch April 13, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review These Pull Requests require review from project members PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
3 participants