Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] wdio-browserstack-service using the wrong session url when w3c properties are enforced #6683

Conversation

tribecalledtest
Copy link
Contributor

@tribecalledtest tribecalledtest commented Apr 9, 2021

Proposed changes

With the webdriver upgrade to v7, W3C valid properties are enforced by default. This means we have to change app to appium:app when specifying capabilities for browserstack.

However, this change is not reflected in the actual wdio-browserstack-service, causing issues around updating sessions. Without this change, every update to the browserstack session will error with a 404 when only using appium':app property for capabilities

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@tribecalledtest tribecalledtest force-pushed the browserstack-service-app-automate-update-fix branch 2 times, most recently from 8b544f6 to 6c05b2b Compare April 9, 2021 17:29
@tribecalledtest tribecalledtest force-pushed the browserstack-service-app-automate-update-fix branch from 6c05b2b to f459f05 Compare April 9, 2021 17:32
@tribecalledtest tribecalledtest changed the title Browserstack service app automate update fix [BUGFIX] wdio-browserstack-service using the wrong session url when w3c properties are enforced Apr 9, 2021
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👌

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 12, 2021
@christian-bromann christian-bromann merged commit 73ee62e into webdriverio:main Apr 12, 2021
@tribecalledtest tribecalledtest deleted the browserstack-service-app-automate-update-fix branch April 12, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants