Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove done callback in Jasmine #6687

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Remove done callback in Jasmine #6687

merged 2 commits into from
Apr 12, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #6685

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann requested a review from a team April 12, 2021 07:41
wswebcreation
wswebcreation approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Just one question, this will still work if WDIO is in Async mode

@christian-bromann
Copy link
Member Author

Just one question, this will still work if WDIO is in Async mode

Yes. It is just Jasmine that now accepts promises.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 12, 2021
@wswebcreation
Copy link
Member

Yes. It is just Jasmine that now accepts promises.
Then merge and release it 😜

@christian-bromann christian-bromann merged commit 86ff2b0 into main Apr 12, 2021
@christian-bromann christian-bromann deleted the cb-jasmine-cb branch April 12, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executeHooksWithArgs fn throws DEPRECATION notice in Jasmine
2 participants
@christian-bromann @wswebcreation