Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wdio-wait-for install via cli #6858

Merged
merged 1 commit into from May 15, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #6857

Also moved it a bit up as it might be more generally valuable to use than other services.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label May 14, 2021
@christian-bromann christian-bromann requested a review from a team May 14, 2021 08:51
@christian-bromann christian-bromann merged commit 39e04f6 into main May 15, 2021
@christian-bromann christian-bromann deleted the cb-fix-wait-for-cli-install branch May 15, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on attempt to install wdio wait for with wdio cli
1 participant