Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove scripts from log payload #6965

Merged
merged 3 commits into from Jun 3, 2021
Merged

fix: Remove scripts from log payload #6965

merged 3 commits into from Jun 3, 2021

Conversation

OlaoluwaM
Copy link
Contributor

Proposed changes

Added check for script property in payload and returned placeholder if it existed. Checks were the same as those for the file property on the results object. Resolves issue #6714

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@OlaoluwaM
fix: Remove scripts from log payload
8a6472c 
Added check for `script` property in payload and returned placeholder if it existed. Checks were the same as those for the file property on the `results` object

Resolves issue webdriverio#6714
@OlaoluwaM
feat: Replaced previous placeholder text
d5bbfd1 
Changed the default placeholder for the script from 'Payload'
to '"Script<base64>"'. I also made the new default value a
constant in case it is needed elsewhere in the file

Resolves Issue: webdriverio#6921
@OlaoluwaM
test: extended 'transformCommandLogResult'
e1762e5 
Extended test to cater for default script placeholder
functionality

Resolves Issue: webdriverio#6921
christian-bromann
christian-bromann approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you 👌

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jun 3, 2021
@christian-bromann christian-bromann merged commit 318ebfe into webdriverio:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlaoluwaM @christian-bromann