fix hyperlink on announcementbar #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinheitzman
requested changes
Jul 30, 2021
website/docusaurus.config.js
Outdated
| @@ -54,7 +54,7 @@ module.exports = { | |||
| announcementBar: { | |||
| id: 'supportus', | |||
| content: | |||
| '⭐️ If you like WebdriverIO, give it a star on <a target="_blank" rel="noopener noreferrer" href="https://github.com/${organizationName}/${projectName}">GitHub</a>! ⭐️', | |||
| '⭐️ If you like WebdriverIO, give it a star on <a target="_blank" rel="noopener noreferrer" href="https://github.com/webdriverio/webdriverio">GitHub</a>! ⭐️', | |||
There was a problem hiding this comment.
Good catch!
The variables are defined at the top of this file, however the string wasn't a string template. Instead do the following.
Suggested change
| '⭐️ If you like WebdriverIO, give it a star on <a target="_blank" rel="noopener noreferrer" href="https://github.com/webdriverio/webdriverio">GitHub</a>! ⭐️', | |
| `⭐️ If you like WebdriverIO, give it a star on <a target="_blank" rel="noopener noreferrer" href="https://github.com/${organizationName}/${projectName}">GitHub</a>! ⭐️`, |
There was a problem hiding this comment.
Done as suggested. I should have thought about this. 👍
There was a problem hiding this comment.
No worries, thanks for fixing this. LGTM 👍
erwinheitzman
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this fixes a hyperlink redirect to repo from websites announcement bar
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers