New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added real time reporting to spec reporter #7572
Conversation
@praveendvd thanks for taking a stab at this. Do you have a gif animation how this looks like? Also I believe we should make this optional as it adds additional clutter to stdout. |
I already added that in previous comment , could you have a look |
This is with logging set to silent in config file |
@praveendvd @christian-bromann are you sure that for It is riduculus that we call console.log() when we have @wdio/logger... |
Could you let me know how to use the logger ? i used this.write but it flushes the output only after the execution completes. Doesnt behave in a realtime manner |
@christian-bromann The test fails for the sync setup and is not related to this pull request i guesss. Could you have a look Thank you 👏👍 |
I don't know. Need investigation why it doesn't print "realtime". I think if logger is not worked as you desired it is not the reason to use console.log(). |
@praveendvd I am working on fixing the |
@BorisOsipov @christian-bromann replaced console.log with logger and explicit log.level info |
@christian-bromann Changed logger to event , now we send a realtimereport event that will log to console . We can throw this event from any reporter |
I added the change but i strogly believe logger will be much more useful as @BorisOsipov mentioned. This implementation works well if the loglevel is silent else the status will get hidden in the sea of logs that we get from wdio. IF we use logger , then user can opt of point it to a file if required so that they can see it in a much more cleaner way . so the new implementation works exactly the same as if we use logger, but doesnt have option to write to a file. should we implement a flag that allows to write to a file ? but for real time i am not sure if a file write is required or not |
Just added some minor formatting adjustments and renamed the new option from |
There seems to be a typing issue with Jest. I will go ahead and merge and check in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this is awesome 👍
Proposed changes
This pull request logs the current test status (Pass , failed ,skipped) for spec reporter .
This will fix :
Allow real time reporting of reporters using WDIO Testrunner #7532
Types of changes
Checklist
Further comments
Test will be added
Reviewers: @webdriverio/project-committers