Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter typing examples #7671

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Stricter typing examples #7671

merged 4 commits into from
Nov 9, 2021

Conversation

Badisi
Copy link
Contributor

@Badisi Badisi commented Nov 9, 2021

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

I have made edits online via github editor so if someone could just test it prior to validate it.
Thanks !

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 9, 2021
@christian-bromann christian-bromann merged commit beb094d into webdriverio:main Nov 9, 2021
@Badisi Badisi deleted the strict-typing-examples branch November 9, 2021 20:47
@christian-bromann christian-bromann mentioned this pull request Nov 11, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Badisi @christian-bromann