Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly wait for window handle to be picked up in DevTools #7677

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #7619

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 10, 2021
@christian-bromann christian-bromann requested a review from a team November 10, 2021 09:05
Copy link
Contributor

@praveendvd praveendvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avikha
Copy link

avikha commented Nov 10, 2021

@christian-bromann
Thank you! It is a super nice solution.
I've learned so much both from the discussion we had and from the code. Thanks!
This is a super nice project and I'd like to participate more when I'll have more time.

@christian-bromann christian-bromann merged commit 2c934f6 into main Nov 10, 2021
@christian-bromann christian-bromann deleted the cb-wait-for-window-handles branch November 10, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
3 participants