Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebDriver shadow commands in DevTools bridge #7689

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

To stay compliant with the WebDriver spec in our devtools bridge here are the shadow commands that were added to the protocol files in #7682.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann requested a review from a team November 11, 2021 13:53
@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Nov 11, 2021
@christian-bromann
Copy link
Member Author

I will go ahead and merge to I can release this with the mentioned PR.

@christian-bromann christian-bromann merged commit 804b0b3 into main Nov 11, 2021
@christian-bromann christian-bromann deleted the cb-shadow-commands-in-devtools branch November 11, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant