Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): accepting a prompt preserves the default value. Closes #7744 #7746

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

jan-molak
Copy link
Contributor

Proposed changes

As discussed with @christian-bromann in #7744, this PR fixes acceptAlert devtools command so that it preserves the default value of a JavaScript prompt.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2021

CLA Signed

The committers are authorized under a signed CLA.

@jan-molak
Copy link
Contributor Author

@christian-bromann - let me know if there is any specific place where we should add tests for this fix? The only test I found in this area was for the devtools dialogHandler, but I don't see any tests for the acceptAlert command specifically? Perhaps I'm missing something. Thanks!

@jan-molak
Copy link
Contributor Author

@christian-bromann - Looks like some connectivity issues with e2e tests on CI?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 .. thanks a lot!

@christian-bromann
Copy link
Member

It seems like the Mac test is broken in main. Will look at it separately.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 24, 2021
@christian-bromann christian-bromann merged commit fa3af3a into webdriverio:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants