Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yargs interface usage #8303

Merged
merged 8 commits into from
May 10, 2022
Merged

Update yargs interface usage #8303

merged 8 commits into from
May 10, 2022

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented May 4, 2022

Proposed changes

Updating the eslint parser has caused code in the cli to break as it couldn't find the property _ in the yargs argv object anymore. My assumption is that we haven't updated the way we use yargs in a while and interfaces have changed that discourage the usage of this property. I have updated it which caused the type issues to go away.

According to the yargs docs:

Calling .parse() with no arguments is equivalent to calling .argv

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant