Support for mocha's 'qunit' interface #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +19,7 @@ module.exports.run = function(config, specs, capabilities) { | |||
| requires = config.mochaOpts.require, | |||
| runner; | |||
|
|
|||
| if(typeof config.mochaOpts.ui !== 'string' || !config.mochaOpts.ui.match(/(bdd|tdd)/i)) { | |||
| if(typeof config.mochaOpts.ui !== 'string') { | |||
There was a problem hiding this comment.
Mocha may have new interfaces added to it in the future. This sort of thing shouldn't be hard-coded.
There was a problem hiding this comment.
if we have it hard coded in the interfaces object why not here?
There was a problem hiding this comment.
Because writing it this way makes it so that the worst that happens for interfaces you don't support is that generators won't work. The worst case for the way you wrote it is that it reverts to an entirely different interface.
|
Ok, looks good. Thanks for the explanations. |
christian-bromann
added a commit
that referenced
this pull request
Oct 28, 2015
Support for mocha's 'qunit' interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.