Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moz:debuggerAddress in DesiredCapabilities #8355

Closed
wants to merge 1 commit into from

Conversation

just-boris
Copy link
Contributor

@just-boris just-boris commented May 18, 2022

Proposed changes

Allow moz:debuggerAddress capability which is described here: https://firefox-source-docs.mozilla.org/testing/geckodriver/Capabilities.html

Ironically, the webdriverio documentation also mentions this feature, but it is missing in types.

Tested the change locally, works well with Geckodriver v0.31.0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 18, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: just-boris / name: Boris Serdiuk (defa7ce)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 18, 2022
@christian-bromann
Copy link
Member

@just-boris mind signing the CLA with the email you've used to make the commit?

@just-boris
Copy link
Contributor Author

Sure, need to check some stuff internally first. I will put this PR out of drafts when it is ready

@christian-bromann
Copy link
Member

Given this has been pending for so long I went ahead and applied the change. If you have started the CLA process with your company please continue so that next time it is gonna be faster. Thanks for the suggestion.

@just-boris just-boris deleted the patch-1 branch June 29, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants