Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #8354 #8379

Merged
merged 4 commits into from
May 30, 2022
Merged

Fix for bug #8354 #8379

merged 4 commits into from
May 30, 2022

Conversation

joshskumar
Copy link
Contributor

@joshskumar joshskumar commented May 28, 2022

Proposed changes

#8354 is addressed by this PR

I had crossed compared the document and saw there was a difference in the endpoint and data type defined as per the document

the endpoint is : /session/{session id}/webauthn/authenticator
and as per the document :
extensions is string array

So made the changes to the Json.

Types of changes

#8354 is addressed by this PR

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

there are no tests in the Protocol Package so have not added any tests

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Member

Awesome, thanks! 👍

@christian-bromann christian-bromann merged commit 7ac4026 into webdriverio:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants