Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing suite causing error in wdio-mocha-framework #8974

Merged
merged 1 commit into from Oct 7, 2022

Conversation

Joosakur
Copy link
Contributor

@Joosakur Joosakur commented Oct 6, 2022

Proposed changes

Adding a null-check to fix an earlier breaking change. Fixes #8973

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Joosakur / name: Joosa Kurvinen (503a2e0)

@christian-bromann
Copy link
Member

Nice simple fix! Mind raising the same PR for the v7 branch so we can release it for the current stable version?

@christian-bromann
Copy link
Member

Why did this PR get closed?

@Joosakur
Copy link
Contributor Author

Joosakur commented Oct 7, 2022

Why did this PR get closed?

I closed it as I first understood that I should have made the PR against v7 instead 😅 but got you now. I'll leave this open and create another fresh PR against the v7 branch later 👍

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍

@christian-bromann christian-bromann merged commit 0b7534c into webdriverio:main Oct 7, 2022
@Joosakur Joosakur deleted the fix#8973 branch October 10, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: TypeError: Cannot read properties of undefined (reading 'duration')
2 participants