Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use available Cucumber tag feature for Allure label instead of Feature name #9721

Merged
merged 1 commit into from Feb 7, 2023
Merged

Use available Cucumber tag feature for Allure label instead of Feature name #9721

merged 1 commit into from Feb 7, 2023

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Feb 6, 2023

Proposed changes

When Cucumber tag feature is presented at scenario or feature level it should be used as Allure label feature value for Allure test case (now it's always equal to Cucumber Feature name)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BorisOsipov what do you think?

packages/wdio-allure-reporter/tests/__fixtures__/cucumber.ts Outdated Show resolved Hide resolved
packages/wdio-allure-reporter/tests/__fixtures__/cucumber.ts Outdated Show resolved Hide resolved
packages/wdio-allure-reporter/tests/cucumber.suite.test.ts Outdated Show resolved Hide resolved
@valfirst valfirst force-pushed the use-cucumber-tag-feature-for-allure-label-if-available branch from 0455463 to 7ca3c4c Compare February 6, 2023 17:49
@valfirst valfirst force-pushed the use-cucumber-tag-feature-for-allure-label-if-available branch from 7ca3c4c to 6349d56 Compare February 6, 2023 17:49
@christian-bromann
Copy link
Member

Thanks for the patch @valfirst , if you like to see this feature in v7 please make the same PR to the v7 branch.

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Feb 7, 2023
@christian-bromann christian-bromann merged commit 875bedc into webdriverio:main Feb 7, 2023
@valfirst valfirst mentioned this pull request Feb 7, 2023
Merged
8 tasks
@BorisOsipov BorisOsipov mentioned this pull request Feb 7, 2023
Merged
8 tasks
@valfirst valfirst deleted the use-cucumber-tag-feature-for-allure-label-if-available branch February 8, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisOsipov BorisOsipov BorisOsipov approved these changes

@christian-bromann christian-bromann Awaiting requested review from christian-bromann

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valfirst @christian-bromann @BorisOsipov