fix(umd): update script to accomodate Weback CLI v4

webex · Feb 24, 2021 · d38b847 · d38b847
1 parent c37bbc4
commit d38b847
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tooling/lib/build.js b/tooling/lib/build.js
@@ -107,7 +107,7 @@ exports.buildUMDScript = async function buildUMDScript() {
 
   // reminder: samples:build calls this script, not webpack
   // hence we must call webpack here
-  const [cmd, ...args] = `webpack --color ${(process.env.NODE_ENV === 'development') ? '--mode development' : '--mode production'} --umd`.split(' ');
+  const [cmd, ...args] = `webpack --color ${(process.env.NODE_ENV === 'development') ? '--mode development' : '--mode production'} --env umd`.split(' ');
   const webpack = spawn(cmd, args, {
     stdio: 'pipe',
     // Spawn fix for Windows

diff --git a/webpack.config.js b/webpack.config.js
@@ -20,7 +20,7 @@ module.exports = (env = process.env.NODE_ENV || 'production', args) => ({
     library: 'Webex',
     libraryTarget: 'umd',
     sourceMapFilename: '[file].map',
-    path: args && args.umd ? // samples:test fix since its called as a function
+    path: args && args.env && args.env.umd ? // samples:test fix since its called as a function
       `${path.resolve(__dirname)}/packages/node_modules/webex/umd` :
       `${path.resolve(__dirname)}/packages/node_modules/samples`
   },