Tidy up util.php

[janopae]

util.php only contains unused functions + the connect function, which is only used exactly one time in the SlimdumpCommand.php file, and I think, this is where the function belongs.

[coveralls]

Coverage decreased (-2.3%) to 67.647% when pulling f227b13 on TidyUpUtil.php into ecacd6f on master.

[mpdude]

Seems reasonable. Are you sure that the other functions are really unused? If so, I'm fine with this.

[MalteWunsch]

From an object oriented point of view, I don't think the command should have the responsibility to create a database connection. For me, the command is merely the bridge between the console and the start of the application. Creating a database connection seems to be some other infrastructure problem. (Looking into the connect method, it does not seem to be very worthy anyway.) I think the dump method should be extracted to a task class as well.

If you think the advantage of getting rid of the util.php outweighs this problem, I'd suggest to move the method into the lines below the other protected methods, because a) this follows the execution and reading flow (read the class like a new article), b) the other protected methods are overwriting their heritage and c) the connect method should be private.

[janopae]

Being already home of the dump()-function, SlimdumpCommand.php seemed to be the best place for connect in the current structure of the application, at least it's much better than having it in a separate file outside the src-directory inside the public namespace, where it has been originally.

Putting all functions that really do something into another class looks like a good idea, but practically, I don't see the need for that at the moment, as the SlimdumpCommand-class is easy to read and works well.

[MalteWunsch]

[polarbirke]

https://en.wikipedia.org/wiki/Broken_windows_theory

[janopae]

Okay, yeah, you convinced me, we should definitively do that, but we should do it in a separate pull request.