Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path to git binary on Windows runners #140

Merged
merged 1 commit into from Oct 19, 2022
Merged

Fix path to git binary on Windows runners #140

merged 1 commit into from Oct 19, 2022

Conversation

mpdude
Copy link
Member

@mpdude mpdude commented Oct 19, 2022 •
edited

This PR fixes an apparently wrong path to the git binary that was added in #136.

According to actions/checkout#928 (comment), the path should not contain the usr/ part, although for ssh-add and ssh-agent, it has to.

@mpdude
Copy link
Member Author

mpdude commented Oct 19, 2022

@ochococo 👀 agree?

@ochococo
Copy link
Contributor

Thanks @mpdude, good catch, LGTM 🟢

@mpdude mpdude merged commit 8a9e20a into master Oct 19, 2022
@mpdude mpdude deleted the fix-windows-path branch October 19, 2022 12:55
@ochococo ochococo mentioned this pull request Oct 19, 2022
Closed
@sfullerbeckman
Copy link

sfullerbeckman commented Oct 19, 2022 •
edited

@mpdude @ochococo , can this bugfix be released today? Would love to use this ASAP

@ochococo
Copy link
Contributor

@sfullerbeckman you can use commit instead of version: #136 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpdude @ochococo @sfullerbeckman