feat!: hide data-v-inspector in html
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the |
|
Disabled it in Vue 2 for now. And yeah, for Nuxt it's due to the |
|
This PR to Vue core fixes for Nuxt: vuejs/core#9328 |
|
I guess we could proceed with this PR, as it's not a bit here. Once Vue shipped it in a new version, the bug will be automatically fixed. |
webfansplz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, for most cases, we no longer render
data-v-inspectorin the HTML. This is done by hijacking vnode and passing a non-enumerable prop for the overlay client to grab. The previous approach still works as a fallback.This could be a breaking change as the vite plugin now exposes an array of two plugins.
And since the
unpluginversion seems to be only supporting Vite, I guess it might be better to deprecate that package maybe? For Nuxt usage, I think we could recommend using Nuxt DevTools.