Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim #11

Closed
wants to merge 4 commits into from
Closed

Trim #11

wants to merge 4 commits into from

Conversation

ybobkova
Copy link
Contributor

@ybobkova ybobkova commented May 9, 2015

The string is trimmed by autocomplete.
The function added that creates a tabButtonItem with an identifier. It is needed for the automatical filling.

@pscheit
Copy link
Member

pscheit commented May 9, 2015

  1. from this description its really difficult to tell, what you're trying to accomplish (and y?)
  2. please split the commits into 2 Pull Requests becuase I can't see how trim is related to the DropBoxButtonItem?
  3. The PR cannot be merged because there are merge conflicts, please resolve them

@pscheit pscheit closed this May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants