Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "EmptyLineBetweenBlocks" issue in src/routes/measurement/style.scss #28

Closed
zoeyfrisart opened this issue Jan 17, 2018 · 0 comments
Closed

Fix "EmptyLineBetweenBlocks" issue in src/routes/measurement/style.scss #28

zoeyfrisart opened this issue Jan 17, 2018 · 0 comments
Labels
codeclimate

Comments

@zoeyfrisart
Copy link

Rule declaration should be followed by an empty line

https://codeclimate.com/github/webgem-xyz/UVA-React/src/routes/measurement/style.scss#issue_5a5f274b7eaf110001000059
zoeyfrisart pushed a commit that referenced this issue Jan 18, 2018
Merge pull request #35 from webgem-xyz/Media
23dc6f5 
✨  Added Media Component
✨  Added map & remove measurement button to Measurement Component
✨  Added MeasurementRow Component ( thx @Coen )

🎨  Made code of the Measurement Component DRY by moving measurementRow to component (#17 #18 #19 #20 #21 #22) ( Thx @Coen )
🎨  Changed color values from #7e7e7e and #fafafa to use var(--var-name)
🎨  Updated Media Component to use measurementRow (DRY)
🎨  Fixed code styling issues ( #25 #27 #28 #30 ) ( Thx @Coen )
🎨  Changed readme.md to README.md

🐛  Fixed items being in the wrong order ( #41 )
🐛  Quickfix for issues ( #46 #47 )
🐛  Moved syncState out of components in to src/components/home.js ( #31 ) ( This fix has been temporarily disabled due to #46 & #47 )
🐛  Changed font-weight: 900; to font-weight: 700; as the font does not support a font-weight of 900.
🐛  Changed Media Component from path="/media/:mediaId" to path="/med/:mediaId" so the Item Component actually sends you to the correct view when u click a media measurement.

📝  Added measurementRow to README
📝  Added removeMeasurement function as accepted prop for the Measurement Component
📝  Fixed spelling mistakes in ISSUE_TEMPLATE.md
📝  Updated README to add the right props to the Media Component
📝  Fixed spelling mistake in CHANGELOG.md on line 40

❗️ This build contains temporarily fixes. These issues should be resolved properly as soon as possible.

Thx @Coen for a fixing a lot of the issues in the Measurement Component.
Thx @ThijsvanRijn for reviewing the changes made.
@snyk-bot snyk-bot mentioned this issue Jan 14, 2022
Open
@zoeyfrisart zoeyfrisart mentioned this issue Oct 7, 2022
Open
@zoeyfrisart zoeyfrisart mentioned this issue Oct 20, 2023
Open
@zoeyfrisart zoeyfrisart mentioned this issue Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codeclimate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoeyfrisart