Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Component measurement & media do not always render properly first load #46

Closed
zoeyfrisart opened this issue Jan 18, 2018 · 0 comments
Closed

🐛 Component measurement & media do not always render properly first load #46

zoeyfrisart opened this issue Jan 18, 2018 · 0 comments
Labels
Breaking ❕ bug Something isn't working Confirmed Need more info
Milestone
V2.1

Comments

@zoeyfrisart
Copy link

zoeyfrisart commented Jan 18, 2018 •
edited
Loading

When switching to Measurement or Media Component it will not always render the component properly. (Either wrong styling or props not being passed down (even with componentWillReceiveProps() ).

How we do it now

  • Grab the measurement the user is currently viewing from the object measurements. Measurements in synced from src/components/home/index.js

Why does this need improving.

  • Component will not show data on first render.

What would we need to change.

  • Unclear we need to determine what the cause is for a possible fix.

Which files are affected.

  • src/routes/measurement/index.js
  • src/routes/media/index.js

Ways to reproduce this issue

  • Go to overview
  • Click a item.
  • Most of the time it will not load the item properly on first render.

Estimated time needed to change.

Fixing this issue will proberaly take around 3 to 4 hours.
A quickfix would be fast but would harm the long term performance and maintainability of our app
@zoeyfrisart zoeyfrisart added bug Something isn't working Need more info labels Jan 18, 2018
@zoeyfrisart zoeyfrisart mentioned this issue Jan 18, 2018
Closed
zoeyfrisart pushed a commit that referenced this issue Jan 18, 2018
🐛 Quickfix for #46 & #47
b9d6c40
zoeyfrisart pushed a commit that referenced this issue Jan 18, 2018
Merge pull request #35 from webgem-xyz/Media
23dc6f5 
✨  Added Media Component
✨  Added map & remove measurement button to Measurement Component
✨  Added MeasurementRow Component ( thx @Coen )

🎨  Made code of the Measurement Component DRY by moving measurementRow to component (#17 #18 #19 #20 #21 #22) ( Thx @Coen )
🎨  Changed color values from #7e7e7e and #fafafa to use var(--var-name)
🎨  Updated Media Component to use measurementRow (DRY)
🎨  Fixed code styling issues ( #25 #27 #28 #30 ) ( Thx @Coen )
🎨  Changed readme.md to README.md

🐛  Fixed items being in the wrong order ( #41 )
🐛  Quickfix for issues ( #46 #47 )
🐛  Moved syncState out of components in to src/components/home.js ( #31 ) ( This fix has been temporarily disabled due to #46 & #47 )
🐛  Changed font-weight: 900; to font-weight: 700; as the font does not support a font-weight of 900.
🐛  Changed Media Component from path="/media/:mediaId" to path="/med/:mediaId" so the Item Component actually sends you to the correct view when u click a media measurement.

📝  Added measurementRow to README
📝  Added removeMeasurement function as accepted prop for the Measurement Component
📝  Fixed spelling mistakes in ISSUE_TEMPLATE.md
📝  Updated README to add the right props to the Media Component
📝  Fixed spelling mistake in CHANGELOG.md on line 40

❗️ This build contains temporarily fixes. These issues should be resolved properly as soon as possible.

Thx @Coen for a fixing a lot of the issues in the Measurement Component.
Thx @ThijsvanRijn for reviewing the changes made.
@zoeyfrisart zoeyfrisart added this to the V2.1 milestone Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking ❕ bug Something isn't working Confirmed Need more info
Projects
None yet
Milestone
V2.1
Development

No branches or pull requests
1 participant
@zoeyfrisart