Skip to content

Commit

Permalink
#647 fix html value if inline editing have not changed it
Browse files Browse the repository at this point in the history
having a 'formatted name' and an inplace editor for the 'plain name' confused the final result as when starting the inplace edit it changed the html value of the tag to the plain value, but if nothing was done, it have not set it back to the formatted value.
now the onFinish event of the editInPlace is handled and resets the tag's value to the formatted one
  • Loading branch information
kecso committed Oct 23, 2015
1 parent d652487 commit cf1d226
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ define([
value: self.name,
onChange: function (oldValue, newValue) {
self.__onNodeTitleChanged(oldValue, newValue);
},
onFinish: function () {
self.skinParts.$name.text(self.formattedName);
self.skinParts.$name.attr('title', self.formattedName);
}
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ define([
value: self.name,
onChange: function (oldValue, newValue) {
self.__onNodeTitleChanged(oldValue, newValue);
},
onFinish: function () {
self.$name.text(self.formattedName);
self.$name.attr('title', self.formattedName);
}
});
}
Expand Down

0 comments on commit cf1d226

Please sign in to comment.