Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a branch then loading it immediately fails with "there is no such branch!" #106

Closed
ksmyth opened this issue Dec 10, 2014 · 2 comments
Closed

Creating a branch then loading it immediately fails with "there is no such branch!" #106

ksmyth opened this issue Dec 10, 2014 · 2 comments
Assignees
@kecso

Comments

@ksmyth
Copy link
Contributor

ksmyth commented Dec 10, 2014

Seems to be because storage/failsafe.js's setBranchHash calls callback immediately.
ksmyth added a commit that referenced this issue Dec 10, 2014
@ksmyth
#106 fix: need to wait for server to get branch creation message
718ea86
ksmyth added a commit that referenced this issue Dec 10, 2014
@ksmyth
fix #106: need to wait for server to get branch creation message
64d15bc
@kecso
Copy link
Member

kecso commented Dec 12, 2014

  1. failsafe has to respond immediately to setBranchHash (if it seems ok as far as the client concerned) because that makes possible to burst changes from a single client (like everything would happen synchronously)
  2. could you please give some details? (in my setup it worked just fine - I called createBranchAsync and SelectBranchAsync continously / there were some projectPanel related error, but the creation and selection happened correctly)

@ksmyth
Copy link
Contributor Author

ksmyth commented Feb 10, 2015

I don't know how to repro this. Closing.

@ksmyth ksmyth closed this as completed Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kecso kecso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksmyth @kecso