Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectNavigatorController: race on project load #109

Closed
ksmyth opened this issue Dec 12, 2014 · 2 comments
Closed

ProjectNavigatorController: race on project load #109

ksmyth opened this issue Dec 12, 2014 · 2 comments
Assignees
@lattmann
Labels
Bug UX/UI

Comments

@ksmyth
Copy link
Contributor

ksmyth commented Dec 12, 2014

If you go to:
http://localhost:8855/?project=AdmEditor

AdmEditor does not exist in the navigation bar
ProjectNavigatorController.js:836 ProjectNavigatorController.selectBranch
client.js:341 started addon null

Looks like a race between getFullProjectsInfoAsync and selectBranch
@lattmann
Copy link
Contributor

#73 takes care of this. An error is still logged into the console, but the code is functional.

@ksmyth ksmyth closed this as completed Feb 10, 2015
@ksmyth
Copy link
Contributor Author

ksmyth commented Feb 10, 2015

lattmann's comment is correct. Closing the issue.

lattmann pushed a commit that referenced this issue Apr 7, 2015
#47 #109 #73 get full project list, if ProjectNavigator does not have…
38e8bb7 
… the project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lattmann lattmann

Labels
Bug UX/UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksmyth @lattmann