Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration structure. #205

Closed
pmeijer opened this issue Mar 3, 2015 · 8 comments
Closed

Update configuration structure. #205

pmeijer opened this issue Mar 3, 2015 · 8 comments

Comments

@pmeijer
Copy link
Contributor

pmeijer commented Mar 3, 2015

var config = {

server: {
    port: 8888,
    sessionCookieId: 'webgmeSid',
    sessionCookieSecret: 'meWebGMEez',
    https: {
        enable: false,
        certificateFile: './src/bin/proba-cert.pem',
        keyFile: './src/bin/proba-key.pem'
    }
},

client: {
    appDir: './src/client',
    // Used in client/WebGME.js to load initial project.
    defaultProject: {
        name: null,
        branch: null,
        node: null
    }
},

mongo: {
    uri: 'mongodb://127.0.0.1:27017/multi',
    options: {
        w: 1,
        'native-parser': true,
        auto_reconnect: true,
        poolSize: 20,
        socketOptions: {keepAlive: 1}
    }
},

socketIO: {
    reconnect: false,
    'connect timeout': 10,
    'reconnection delay': 1,
    'force new connection': true,
    transports: ['websocket']
},

log: {
    debug: false,
    level: 1, // 5 = ALL, 4 = DEBUG, 3 = INFO, 2 = WARNING, 1 = ERROR, 0 = OFF
    file: 'server.log'
},

authentication: {
    enable: false,
    salts: 10,
    allowGuests: false,
    logOutUrl: '/',
    guestAccount: 'anonymous'
},

blob: {
    type: 'FS', //'FS', 'S3'
    fsDir: './blob-local-storage',
    s3: {}
},

executor: {
    enable: false,
    nonce: null
},

plugin: {
    allowServerExecution: false,
    basePaths: ['./src/plugin/coreplugins'],
},

rest: {
    secure: false,
    components: {}
},

addOn: {
    enable: true,
    basePaths: ['./src/addon/core']
},

visualization: {
    decoratorPaths: ['./src/client/decorators'],
    visualizerDescriptors: ['./src/client/js/Visualizers.json']
},

storage: {
    keyType: 'plainSHA1', // 'rand160Bits', 'ZSSHA', 'plainSHA1',
    timeout: 10000,
    failSafe: 'memory',
    failSafeFrequency: 10000
},

requirejsPaths: {}

}

@pmeijer
Copy link
Contributor Author

pmeijer commented Mar 3, 2015

I suggest the default port to be 8888 rather than 80 since 80 isn't available on windows.

@pmeijer
Copy link
Contributor Author

pmeijer commented Mar 3, 2015

Perhaps secureREST, httpsecure, sessioncookieid, sessioncookiesecret could be grouped. And authentication and guest might be related too.

@pmeijer pmeijer added this to the v0.8.0 milestone Mar 4, 2015
@pmeijer pmeijer self-assigned this Mar 4, 2015
@ksmyth
Copy link
Contributor

ksmyth commented Mar 4, 2015

I'd suggest consistency in capitalization.
sessioncookieid => sessionCookieId
decoratorpaths => decoratorPaths
also, logFile, logLevel, sessionCookieSecret, httpSecure, mongoUri (or mongoURI)

@ksmyth
Copy link
Contributor

ksmyth commented Mar 4, 2015

Also, are all configuration keys listed? Or are we missing some?

@ksmyth
Copy link
Contributor

ksmyth commented Mar 4, 2015

"guest" really means "allow anonymous access". It could stand to be renamed

@lattmann
Copy link
Contributor

lattmann commented Mar 4, 2015

I suggest to have sub keys per features:

auth: {
// auth specific settings
}

webserver: {
// webserver specific settings
}

rest: {
// rest specific settings
}

ui: {
// decorators + visualizers
}

plugin: {
// plugin specific configs
}

requirejs: {
    path: {}
}

@brollb
Copy link
Contributor

brollb commented Mar 4, 2015

I think "autorecconnect" should be "autoreconnect"

On Wed, Mar 4, 2015 at 10:26 AM Zsolt Lattmann notifications@github.com
wrote:

I suggest to have sub keys per features:

auth: {
// auth specific settings
}

webserver: {
// webserver specific settings
}

rest: {
// rest specific settings
}

ui: {
// decorators + visualizers
}

plugin: {
// plugin specific configs
}

requirejs: {
path: {}
}


Reply to this email directly or view it on GitHub
#205 (comment).

@pmeijer
Copy link
Contributor Author

pmeijer commented Mar 5, 2015

Guys based on your comments I've updated the suggested config. (Some of the options aren't available yet.)

pmeijer pushed a commit that referenced this issue Mar 6, 2015
lattmann pushed a commit that referenced this issue Mar 7, 2015
pmeijer pushed a commit that referenced this issue Mar 7, 2015
pmeijer pushed a commit that referenced this issue Mar 7, 2015
pmeijer pushed a commit that referenced this issue Mar 7, 2015
pmeijer pushed a commit that referenced this issue Mar 7, 2015
lattmann pushed a commit that referenced this issue Mar 7, 2015
lattmann pushed a commit that referenced this issue Mar 7, 2015
lattmann pushed a commit that referenced this issue Mar 9, 2015
lattmann pushed a commit that referenced this issue Mar 9, 2015
lattmann pushed a commit that referenced this issue Mar 10, 2015
lattmann pushed a commit that referenced this issue Mar 10, 2015
pmeijer pushed a commit that referenced this issue Mar 10, 2015
Refactored and deal with node_worker timeouts better.
pmeijer pushed a commit that referenced this issue Mar 10, 2015
pmeijer pushed a commit that referenced this issue Mar 10, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
pmeijer pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
Conflicts:
	src/common/storage/serverstorage.js
	test/common/core/corerel.spec.js
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 11, 2015
lattmann pushed a commit that referenced this issue Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants