Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Q library doesn't suppress any exceptions (use done/nodeify after catches). #354

Closed
ksmyth opened this issue May 1, 2015 · 0 comments

Comments

@ksmyth
Copy link
Contributor

ksmyth commented May 1, 2015

corediff.spec.merge.js throws uncaught exceptions

e.g. https://github.com/webgme/webgme/blob/master/test/common/core/corediff.spec.merge.js#L884 results in:

node ./node_modules/mocha/bin/mocha -R dot --recursive --timeout 10000 test/common/core/corediff.spec.merge.js

unhandled error from callback { [AssertionError: expected '#fa3404d329b0be53648786400db65f301f09b501' to equal '#750269ed92ac349ed65d87ed4a91fe40381ea1a1']
  message: 'expected \'#fa3404d329b0be53648786400db65f301f09b501\' to equal \'#750269ed92ac349ed65d87ed4a91fe40381ea1a1\'',
  showDiff: true,
  actual: '#fa3404d329b0be53648786400db65f301f09b501',
  expected: '#750269ed92ac349ed65d87ed4a91fe40381ea1a1' }

...

1) corediff-merge merge registry changing to the same value:
 Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.

I suggest using q to automatically catch these exceptions like e.g. https://github.com/webgme/webgme/blob/e55cf3a3cb20bb3553156dde6e7730f78d04344e/test/bin/usermanager.spec.js

@kecso kecso added this to the v1.0.0 milestone Sep 3, 2015
@pmeijer pmeijer changed the title corediff.spec.merge.js throws uncaught exceptions Make sure Q library doesn't suppress any exceptions (use done/nodeify after catches). Sep 11, 2015
@pmeijer pmeijer assigned pmeijer and unassigned kecso Sep 24, 2015
@pmeijer pmeijer modified the milestones: v1.0.0, v1.1.0 Sep 25, 2015
@pmeijer pmeijer modified the milestones: v1.2.0, v1.1.0 Oct 26, 2015
@kecso kecso closed this as completed in 0ff36a7 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants