Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

META Decorator attribute not updating #88

Closed
brollb opened this issue Aug 4, 2014 · 3 comments
Closed

META Decorator attribute not updating #88

brollb opened this issue Aug 4, 2014 · 3 comments
Assignees
@lattmann
Labels
Bug Minor
Milestone
v0.8.0

Comments

@brollb
Copy link
Contributor

brollb commented Aug 4, 2014

META decorator not updating attribute type on change.

When I change the attribute from "string" to "float", it still says "string" on the object (though opening the edit panel again shows that it has changed to "float")
@brollb brollb added Bug labels Aug 4, 2014
@brollb
Copy link
Contributor Author

brollb commented Feb 12, 2015

This can be replicated by opening the META editor and changing an existing attribute type without modifying anything else.

Changing the attribute...
edit_attr_before

After (no change):
edit_attr_after

@lattmann lattmann added this to the v0.8.0 milestone Mar 3, 2015
@lattmann lattmann self-assigned this Mar 3, 2015
lattmann pushed a commit that referenced this issue Mar 3, 2015
#88 meta editor rm and add all attributes on change
b2e579a 
Do not use difference between displayed and new attributes. We cannot
detect if the type changed only and the name does not.
@lattmann
Copy link
Contributor

lattmann commented Mar 3, 2015

@brollb please test the fix: issue/88_meta_editor_type_bug

@brollb
Copy link
Contributor Author

brollb commented Mar 3, 2015

Works as of b2e579a

@kecso kecso closed this as completed in 2600fe9 Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lattmann lattmann

Labels
Bug Minor
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@lattmann @brollb