Fixes #563 We should not allow adding instance as descendant #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now the gme concepts checks for every level of containment to avoid crossings in the containment hierarchy and the inheritance chain it is still possible to create loops / crossings in the inheritance chain and containment hierarchy as not all elements can be checked at the time of modification
… collision if they found such node, they remove it on-demand
lattmann
added a commit
that referenced
this pull request
Sep 17, 2015
Fixes #563 We should not allow adding instance as descendant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we detect if a node has inheritance-containment collision (meaning that one of its container nodes as also its ancestor) and remove it from the project.