Allow REST access to raw node data from REST. #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tweaks and improvements to the storage, esp. w.r.t. loadPaths.
| }) | ||
| .catch(function (err) { | ||
| if (err.message.indexOf('not exist') > -1 || err.message.indexOf('Not authorized to read') > -1 ) { | ||
| err.status = 404; |
There was a problem hiding this comment.
not authorized status code is 403
There was a problem hiding this comment.
It was requested that if the user doesn't have read access the return code should be 404.
For two reasons;
The storage just checks if the user has the project in his/her project list (with read access) and does't check whether the project exists or not.
If the user doesn't have read access, he shouldn't even be able to get information about whether the project exists or not.
kecso
added a commit
that referenced
this pull request
Oct 22, 2015
Allow REST access to raw node data from REST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/projects/[ownerId]/[projectName]/commits/[commitHash]/tree/path/to/object/api/projects/[ownerId]/[projectName]/branches/master/tree/path/to/objectSome tweaks and improvements to the storage, esp. w.r.t. loadPaths.