Refactored the rotate button. #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #663 Introduced new buttons so now we can rotate by dragging on the main button, or we can do one of the following: - rotate left by 90 degrees - rotate right by 90 degrees - rotate left to the closest multiple of 90 degrees (if it is a multiple of 90 degrees, there will be no change) - rotate right to the closest multiple of 90 degrees (-||-) - set rotation to 0 degree - clear rotation info (so reset to the inherited information) We also enhanced the tool-tip of buttons.
| regDegree = 0; | ||
| newDegree = 0; | ||
| } else if (degree === DiagramDesignerWidgetConstants.ROTATION_TOLEFT) { | ||
| newDegree = (regDegree || 0) - ((regDegree || 0) % 90); |
There was a problem hiding this comment.
Why not intialize regDegree with:
regDegree = this._client.getNode(gmeID).getEditableRegistry(REGISTRY_KEYS.ROTATION) || 0;
|
review comments have been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663
Introduced new buttons so now we can rotate by dragging on the main button, or we can do one of the followings:
We also enhanced the tool-tip of buttons.
