Optimized import project functionality. #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the import use the same underlying function as the library update, it always cleared out the sets and meta rules and pointers before inserting the new ones. Due to the nature of the deletion process it takes some time even if there is nothing to remove, so to improve the overall speed, we check if the given node is a new one, and in that case we skip the remove. The bigger a project is the bigger the positive impact of the change (example project was of size 8.7Mb, the import time decreased from 45145.358ms to 11571.499ms). It also improves library updates where the number of new items is big.
| @@ -4313,12 +4313,14 @@ describe('GME client', function () { | |||
| superagent.get(url, function (err, result) { | |||
| expect(err).to.equal(null); | |||
|
|
|||
| expect(result.body).to.deep.equal(refNodeProj); | |||
There was a problem hiding this comment.
Out of curiosity, does this this change really matter?
pmeijer
pushed a commit
that referenced
this pull request
Jan 22, 2016
Optimized import project functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the import use the same underlying function as the library update, it always cleared out the sets and meta rules and pointers before inserting the new ones. Due to the nature of the deletion process it takes some time even if there is nothing to remove, so to improve the overall speed, we check if the given node is a new one, and in that case we skip the remove.
The bigger a project is the bigger the positive impact of the change (example project was of size 8.7Mb, the import time decreased from 45s to 10s).
It also improves library updates where the number of new items is big.