Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - ContactTagsAdder and ContactListsSubscriber should not be dispatched by Contact update/create handler #53

Closed
lruozzi9 opened this issue Apr 22, 2022 · 0 comments · Fixed by #55
Closed

[BUG] - ContactTagsAdder and ContactListsSubscriber should not be dispatched by Contact update/create handler #53

lruozzi9 opened this issue Apr 22, 2022 · 0 comments · Fixed by #55
Assignees
@lruozzi9
Labels
bug Something isn't working

Comments

@lruozzi9
Copy link
Member

Describe the bug
It is not a ContactCreate/UpdateHandler responsibility to dispatch the ContactTagsAdder and ContactListsSubscriber messages. Someone could prefer to handle these messages differently or at a different moment.
@lruozzi9 lruozzi9 added the bug Something isn't working label Apr 22, 2022
@lruozzi9 lruozzi9 self-assigned this Apr 22, 2022
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Remove dispatching tags and lists subscriber message from contact han…
25f1787 
…dlers (#53)
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Dispatch ContactTagsAdder and ContactListsSubscriber messages on Syli…
a1c1afd 
…us events (#53)
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Add EnqueueContactListsSubscriptionCommand (#53)
41b7dfc
@lruozzi9 lruozzi9 mentioned this issue Apr 22, 2022
Merged
1 task
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Add EnqueueContactTagsAdderCommand (#53)
4453a9d
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Remove dispatching tags and lists subscriber message from contact han…
5454771 
…dlers (#53)
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Dispatch ContactTagsAdder and ContactListsSubscriber messages on Syli…
e46413b 
…us events (#53)
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Add EnqueueContactListsSubscriptionCommand (#53)
338e2ce
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Add EnqueueContactTagsAdderCommand (#53)
9d614f8
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Add UpdateContactListsSubscriptionCommand (#53)
e89cf90
lruozzi9 added a commit that referenced this issue Apr 22, 2022
@lruozzi9
Update docs (#53)
2015ddf
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Remove dispatching tags and lists subscriber message from contact han…
38c25f4 
…dlers (#53)
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Dispatch ContactTagsAdder and ContactListsSubscriber messages on Syli…
cc0c8dc 
…us events (#53)
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Add EnqueueContactListsSubscriptionCommand (#53)
11c0d3d
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Add EnqueueContactTagsAdderCommand (#53)
b2f2be9
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Add UpdateContactListsSubscriptionCommand (#53)
328cfb5
lruozzi9 added a commit that referenced this issue Apr 26, 2022
@lruozzi9
Update docs (#53)
34183b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lruozzi9 lruozzi9

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@lruozzi9