Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tags and lists subscription from contact handlers (#53) #55

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Remove tags and lists subscription from contact handlers (#53) #55

merged 7 commits into from
Apr 26, 2022

Conversation

lruozzi9
Copy link
Member

@lruozzi9 lruozzi9 commented Apr 22, 2022 •
edited
Loading

Fixes #53

Changes proposed in this pull request:

  • Remove tags and lists subscription from contact handlers
  • Added command to send to ActiveCampaign all lists subscription
  • Added command to send to ActiveCampaign all tags for contact
  • Added command to update all list subscriptions status from ActiveCampaign
  • Docs these commands

@lruozzi9 lruozzi9 added the enhancement New feature or request label Apr 22, 2022
@lruozzi9 lruozzi9 self-assigned this Apr 22, 2022
@lruozzi9 lruozzi9 force-pushed the 53-bug-contacttagsadder-and-contactlistssubscriber-should-not-be-dispatched-by-contact-updatecreate-handler branch from 4453a9d to e89cf90 Compare April 22, 2022 15:20
@lruozzi9 lruozzi9 marked this pull request as ready for review April 26, 2022 07:34
@lruozzi9 @LucaGallinari
Apply suggestions from code review
a426e8e 
Co-authored-by: Luca <luke.gallinari@gmail.com>
@lruozzi9 lruozzi9 merged commit c1f3731 into master Apr 26, 2022
@lruozzi9 lruozzi9 deleted the 53-bug-contacttagsadder-and-contactlistssubscriber-should-not-be-dispatched-by-contact-updatecreate-handler branch April 26, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGallinari LucaGallinari LucaGallinari approved these changes

Assignees

@lruozzi9 lruozzi9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - ContactTagsAdder and ContactListsSubscriber should not be dispatched by Contact update/create handler
2 participants
@lruozzi9 @LucaGallinari