Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Database error while creating products without name #148

Closed
lruozzi9 opened this issue Sep 6, 2022 · 1 comment · Fixed by #169
Closed

[BUG] - Database error while creating products without name #148

lruozzi9 opened this issue Sep 6, 2022 · 1 comment · Fixed by #169
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lruozzi9
Copy link
Member

lruozzi9 commented Sep 6, 2022

Describe the bug
It could happen that, while importing products from Akeneo, the attribute used as the name for the product is empty. If this is the case, the importer will not generate any error because the name property on ProductTranslation is nullable. Still, when it tries to persist the product on DB it causes an Integrity constraint violation due to the not nullable constraint on the name column.

Expected behavior
IMHO the plugin should check for the name consistency before trying to persist them on DB. If it is not valid it should throw a PHP exception so that it could be handled by the importer by marking the product as not imported without blocking the entire queue.

@LucaGallinari
Copy link
Member

Here there are a couple of solutions that we can try:
symfony/symfony#35360 (comment)

@mmenozzi mmenozzi added this to the v2.0 milestone Aug 29, 2023
@mmenozzi mmenozzi added this to To do in Release 2.0.0 via automation Aug 29, 2023
@lruozzi9 lruozzi9 moved this from To do to In progress in Release 2.0.0 Sep 1, 2023
@lruozzi9 lruozzi9 moved this from In progress to Review in progress in Release 2.0.0 Sep 1, 2023
Release 2.0.0 automation moved this from Review in progress to Done Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
3 participants