Misc fixes #107
Open
Misc fixes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedding C code into pio assembly files makes for a poor editing experience.
Increasing the output drive strength is enough, no need to output to multiple pins at all.
EXI is basically SPI mode 0. In particular, this means CPHA=0, i.e. the first bit comes out *before* the first clock pulse.
This makes it easier to customize the pinout.
9ary
force-pushed
the
for-upstream
branch
3 times, most recently
from
5e0c1fc
to
89c0990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #105. It includes misc cleanups, fixes two implementation bugs, and decouples the payload from picoboot.
Fixes #22
Fixes #58