Fix: Error in HTML formatter script

Close #1448
webhintio · Oct 25, 2018 · a402a07 · a402a07
1 parent a0ae1c3
commit a402a07
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/formatter-html/src/assets/js/scan/scanner-common.js b/packages/formatter-html/src/assets/js/scan/scanner-common.js
@@ -57,11 +57,11 @@
         var expanded = typeof closeAll !== 'undefined' ? closeAll : childRulesExpanded(element);
 
         if (expanded) {
-            element.innerHTML = 'close all';
+            element.textContent = 'close all';
             element.classList.remove('closed');
             element.classList.add('expanded');
         } else {
-            element.innerHTML = 'expand all';
+            element.textContent = 'expand all';
             element.classList.remove('expanded');
             element.classList.add('closed');
         }
@@ -207,7 +207,6 @@
 
         if (container) {
             container.addEventListener('click', onContainerClick, false);
-            container.addEventListener('toggle', toggleExpand, false);
         }
     };
 
@@ -341,11 +340,18 @@
 
     var contractDetails = function () {
         var elements = Array.prototype.slice.apply(document.querySelectorAll('details[open]'));
+        var expandAllButtons = Array.prototype.slice.apply(document.querySelectorAll('.button-expand-all'));
 
         elements.forEach(function (element) {
             element.removeAttribute('open');
             element.setAttribute('aria-expanded', 'false');
         });
+
+        expandAllButtons.forEach(function (element) {
+            element.textContent = 'expand all';
+            element.classList.add('closed');
+            element.classList.remove('expanded');
+        });
     };
 
     var scrollToLink = function () {

diff --git a/packages/formatter-html/src/views/partials/scan-expand-all.ejs b/packages/formatter-html/src/views/partials/scan-expand-all.ejs
@@ -1 +1 @@
-<button title="expand" class="button-expand-all closed">expand all</button>
+<button title="expand" class="button-expand-all expanded">close all</button>